-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of record system code and migrate all record UI to TGUI #6266
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone through the backend code, still need to review the tgui / test the UIs and test in general. Generally looking ok but theres a lot of changes to code that I'm not familiar with
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
I don't have time to work on this. If someone wants they can pick up this PR in the future, you have my full permission to do whatever you want with it but please credit me. Thank you. |
About the pull request
This pr is part one of a two part plan I have to overhaul the medical record system and give it actual utility. The idea is to improve the medical record keeping mechanic and make it actually useful outside of strictly RP.
Here is the general idea:
The new medical record system will still contain fluff data that really isn't that important but has its usefulness in RP, however, it will be significantly reduced in this domain (you can still put notes and what not). Instead, there will be a new autopsy mechanic that will take its place. The gist is that whenever a scalped marine is brought to the morgue the medical staff can optionally perform an autopsy on them and through that autopsy (it will require a little bit of brain usage since you will have to guess the cause of death) the marines can gain tech points. You are not by any means forced to do it, completely optional.
Part 1
This is the current PR.
respectfullyon discord. I know you can just right click, but the plan will be to restrict that functionality a bit if it's not for frontline use.stolemodified the existing identification computer code to meet my needs and threw in some OOP for future similar computers. I also subtyped the squad changer and modified the ui to align it with the new functionality.Part 2
This is the next planned PR.
I don't have all the details, but the plan is to get a functional autopsy system working and maybe give bonuses for things like exotic species, such as the predator or whatnot (give incentive for the marines to actually kill one). Hopefully this would be the meat and potatoes of the implementation and the autopsy system would have some good mechanics.
Conclusion
If you don't like something and think there is room for improvement please message me on discord. I will be much more receptive there then if you leave hate comments on my pr. I'm open to anything and everything.
For the maintainers, there is plenty of copy pasta that needs to be refactored (single letter vars, silly logic, etc), and i'm on it.
Edit: This pr has essentially turned into an overhaul of the record system in general, with multiple UI changes.
Changelog
🆑
add: Adds autopsy data to medical records
ui: New TGUI UI for viewing security records
ui: Squad modifier is now more intuitive to use, UI tweak.
ui: New TGUI UI for viewing medical records.
code: Refactored the record system and cleaned up legacy code.
/:cl: